-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: implement at
#53
base: main
Are you sure you want to change the base?
Conversation
376ad49
to
4a0943a
Compare
Rebased on top of #58 |
|
Any idea how to fix this? Looks like the ubuntu_latest VM has an obsolete driver (or more likely no driver)
|
I don't think we can get GPU CI without paying someone for it, cc @rgommers . |
Can cupy run on a CPU-only host? |
Yep, that's on my radar to push forward this month, on multiple projects. Please feel free to open a new issue and assign it to me. I think we can hook up a shared GPU runner between this project and
I don't think so. |
I resolved the merge conflicts after adding |
@lucascolley if you don't mind building against array-api-compat git tip until their next release, this PR is ready for final review and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucascolley if you don't mind building against array-api-compat git tip until their next release, this PR is ready for final review and merge
That's fine with me, but might be cleaner to get an array-api-compat release out first unless there are any big blockers.
Let's give @rgommers and @jakevdp time to take a look if they would like to.
Once (or before) this is merged, do you think you could make a PR to my branch at scikit-learn/scikit-learn#30340? I think we will have to transition scikit-learn from using array-api-compat as an optional dependency to vendoring it, but that sounds feasible based on scikit-learn/scikit-learn#30367 (comment).
|
@lucascolley ready for merge and release! 🥳 |
good to proceed @rgommers ? |
Implement a new
at(x, idx)
orat(x)[idx]
function, mocking the syntax of JAX's omonymous method .This is propaedeutic to JAX support in libraries that support the Array API, e.g. scipy.
Moved from data-apis/array-api-compat#205
Blockers