Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/TST: tougher restrictions on array_api_strict #179

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

crusaderky
Copy link
Contributor

  • Run all tests with array-api-strict with all optional capabilities disabled
  • Add nunique support for unknown backends without unique_counts - for example, marray wrapping around JAX.
  • Add apply_where support for unknown backends without boolean index assignment - again for example marray wrapping around JAX (but see Array API capabilities() are incorrect jax-ml/jax#27418)
  • Add apply_where support for sparse arrays

Upstream issues

@lucascolley lucascolley changed the title ENH: tougher restrictions on array_api_strict ENH/TST: tougher restrictions on array_api_strict Mar 25, 2025
@lucascolley lucascolley added enhancement New feature or request testing labels Mar 25, 2025
@lucascolley lucascolley self-requested a review March 25, 2025 18:19
@crusaderky crusaderky force-pushed the array_api_strictest branch 4 times, most recently from a91d82c to dd1de30 Compare March 26, 2025 17:04
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high-level question before reviewing this: what is the motivation for keeping both ARRAY_API_STRICT and ARRAY_API_STRICTEST, rather than just only using the strictest version?

@crusaderky crusaderky force-pushed the array_api_strictest branch from dd1de30 to c853b58 Compare March 27, 2025 17:09
@crusaderky
Copy link
Contributor Author

high-level question before reviewing this: what is the motivation for keeping both ARRAY_API_STRICT and ARRAY_API_STRICTEST, rather than just only using the strictest version?

ARRAY_API_STRICT follows different, more performant code paths. You can see it both in nunique and in apply_where.

Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Guido, looks pretty much there!

@lucascolley lucascolley added this to the 0.7.2 milestone Mar 27, 2025
@lucascolley lucascolley merged commit b41da86 into data-apis:main Mar 27, 2025
11 checks passed
@crusaderky crusaderky deleted the array_api_strictest branch March 27, 2025 19:15
NeilGirdhar pushed a commit to NeilGirdhar/array-api-extra that referenced this pull request Apr 2, 2025
* ENH: tougher restrictions on array_api_strict

* Clean up Backend tests

* Code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants