-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH/TST: tougher restrictions on array_api_strict #179
Conversation
a91d82c
to
dd1de30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high-level question before reviewing this: what is the motivation for keeping both ARRAY_API_STRICT
and ARRAY_API_STRICTEST
, rather than just only using the strictest version?
dd1de30
to
c853b58
Compare
ARRAY_API_STRICT follows different, more performant code paths. You can see it both in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Guido, looks pretty much there!
* ENH: tougher restrictions on array_api_strict * Clean up Backend tests * Code review
nunique
support for unknown backends withoutunique_counts
- for example,marray
wrapping around JAX.apply_where
support for unknown backends without boolean index assignment - again for examplemarray
wrapping around JAX (but see Array APIcapabilities()
are incorrect jax-ml/jax#27418)apply_where
support for sparse arraysUpstream issues
capabilities()
are incorrect jax-ml/jax#27418any()
fails when wrapping JAX and PyTorch mdhaber/marray#99