Skip to content
This repository was archived by the owner on Jan 6, 2022. It is now read-only.

Add endpoint for admin to create new users#114

Open
joehand wants to merge 2 commits intomasterfrom
admin-createuser
Open

Add endpoint for admin to create new users#114
joehand wants to merge 2 commits intomasterfrom
admin-createuser

Conversation

@joehand
Copy link
Copy Markdown
Collaborator

@joehand joehand commented Jun 26, 2017

Allows admins to create users. This allows skipping of email registration. Useful for centrally managing users or bulk creating users as admin.

@joehand joehand requested a review from pfrazee June 26, 2017 22:09
@joehand
Copy link
Copy Markdown
Collaborator Author

joehand commented Jun 26, 2017

I realized this also skips the email whitelist, which wasn't intended but I think that makes sense.

@pfrazee
Copy link
Copy Markdown
Collaborator

pfrazee commented Jun 26, 2017

I suggest you add tests to make sure you can login and add archives using these accounts. I think you might be missing fields on the user record.

@pfrazee
Copy link
Copy Markdown
Collaborator

pfrazee commented Jun 26, 2017

@pfrazee
Copy link
Copy Markdown
Collaborator

pfrazee commented Jun 26, 2017

Also you need to do the password hashing and etc https://github.com/datprotocol/hypercloud/blob/master/lib/apis/users.js#L61

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants