-
Notifications
You must be signed in to change notification settings - Fork 69
fix: use latest dat-node for network improvements with hyperswarm #649
base: master
Are you sure you want to change the base?
Conversation
fixes #648 |
Built binaries for easier testing: http://vvvvvvaria.org/~luke/dat-desktop%40next.tar.gz |
OK, so the changes are good, I was able to build, LGTM! Bad news is that I still can't share files with this new networking... will try to debug... |
Oh wait, it worked! I tried the dat@next cli and it worked for sharing 🎂 My friend was using my binary for dat-desktop and I was using the dat@next cli. Perhaps I built the binaries incorrectly (it was quite hard in the end...) So, I would say that it will be nice when this is merged and someone who knows what they are doing can publish the new binaries with these changes included. Thanks again for the work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this PR on a windows and mac computer. Both were able to build and start. Creating a folder worked and shared it. Downloading the folder on the other computer found the peer but didn't start synching.
Thanks for testing @martinheidegger! Branch is rotting, oh oh, any bump on getting this merged in once rebased? Thanks and sorry for nagging (but it is gentle, I hope ;)) |
@decentral1se I wish it would work, then the merging was a no-brainer. |
Is this a bug with this branch or is it also reproducible on master @martinheidegger ? |
Contributor checklist:
npm install --package-lock
tool.
Description
Better connectivity: A better DHT and holepunching. The networking stack has been entirely rewritten. See https://github.com/hyperswarm/hyperswarm