Skip to content

Bugfix: adding rounding to calculation of unspecified sample size #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix: adding rounding to calculation of unspecified sample size #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dask_ml/model_selection/_split.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,9 @@ def train_test_split(
test_size = 0.1

if train_size is None and test_size is not None:
train_size = 1 - test_size
train_size = round(1 - test_size, 6)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, the number 6 could be promoted to a named variable to avoid copy-and-paste bugs upon possible updates to this.

Also, I think for some users, the value 6 wouldn't be as effective, as it would for others. Perhaps, this warrants a consideration for introducing a configurable parameter. If such parameter is absent, some default value (eg, 6, as it has been the choice here) could be used as a fallback.

if test_size is None and train_size is not None:
test_size = 1 - train_size
test_size = round(1 - train_size, 6)

if options:
raise TypeError("Unexpected options {}".format(options))
Expand Down