-
Notifications
You must be signed in to change notification settings - Fork 44
feat(sdk): entities for Evo SDK #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 83 files out of 263 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Actions performedReview triggered.
|
|
@codex please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
@claude review |
|
@codex please review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 190 out of 266 changed files in this pull request and generated 11 comments.
Files not reviewed (1)
- .pnp.cjs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/wasm-dpp2/tests/unit/DataContractUpdateStateTransition.spec.mjs
Outdated
Show resolved
Hide resolved
packages/wasm-dpp2/src/state_transitions/batch/token_transitions/token_mint.rs
Outdated
Show resolved
Hide resolved
…n.spec.mjs Co-authored-by: Copilot <[email protected]>
…ns/token_mint.rs Co-authored-by: Copilot <[email protected]>
# Conflicts: # Cargo.lock
| use std::collections::{BTreeMap, BTreeSet}; | ||
|
|
||
| use dpp::dashcore::hashes::Hash; | ||
| use drive::query::vote_poll_contestant_votes_query::ContestedDocumentVotePollVotesDriveQuery; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting
Issue being fixed or feature implemented
SDK returns some JS objects without typing.
What was done?
In further PRs entities and params will be imporved to provide better UX
How Has This Been Tested?
Updated existing tests
Breaking Changes
Evo SDK API is changed
Checklist:
For repository code-owners and collaborators only