Skip to content

feat: remove SPORK_3_INSTANTSEND_BLOCK_FILTERING and SPORK_9_SUPERBLOCKS_ENABLED #7278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 5 commits into from
Apr 12, 2026
Merged

feat: remove SPORK_3_INSTANTSEND_BLOCK_FILTERING and SPORK_9_SUPERBLOCKS_ENABLED #7278

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
afcf3d1
spork: remove SPORK_3_INSTANTSEND_BLOCK_FILTERING and SPORK_9_SUPERBL…
UdjinM6 Apr 9, 2026
ee90879
doc: add release notes for SPORK_3/SPORK_9 removal
UdjinM6 Apr 9, 2026
3d9e80e
refactor: cleanup unused members, includes and forward declaration af…
knst Apr 10, 2026
b2cde07
test, doc: address review suggestions for spork removal
UdjinM6 Apr 10, 2026
18b990b
refactor: move superblock sync check inside !IsTestChain() guard
UdjinM6 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions doc/release-notes-7278.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Removed Sporks
--------------

* `SPORK_3_INSTANTSEND_BLOCK_FILTERING` and `SPORK_9_SUPERBLOCKS_ENABLED` have
been removed. The behaviours they gated (InstantSend conflicting-block
rejection and superblock payments) are now always enabled. These sporks will
Comment thread
UdjinM6 marked this conversation as resolved.
Outdated
no longer appear in the output of the `spork` RPC.

Updated RPCs
------------

* `getblocktemplate` now always reports `superblocks_enabled` as `true`. The
field is retained for backwards compatibility.
Comment on lines +12 to +15
Copy link
Copy Markdown

@thepastaclaw thepastaclaw Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Nitpick: Release notes should mention getblocktemplate sync requirement on test chains

The release notes document that getblocktemplate now always reports superblocks_enabled as true, and that the removed functionality is "permanently enabled across all networks." However, the practical consequence — that getblocktemplate now throws RPC_CLIENT_IN_INITIAL_DOWNLOAD at superblock heights on regtest/testnet/devnet when the node hasn't completed masternode sync — is not called out. This is a subtle but potentially breaking change for test harnesses.

💡 Suggested change
Suggested change
------------
* `getblocktemplate` now always reports `superblocks_enabled` as `true`. The
field is retained for backwards compatibility.
* `getblocktemplate` now always reports `superblocks_enabled` as `true`. The
field is retained for backwards compatibility. On test networks (regtest,
testnet, devnet), `getblocktemplate` now requires masternode sync to be
complete at superblock heights; previously this check was gated by the
now-removed `SPORK_9`.

source: ['claude']

Loading