-
Notifications
You must be signed in to change notification settings - Fork 754
Add interactive quizzes with actionable feedback to FWE #7076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the educational experience on the FWE site by integrating a new interactive quiz system. This system allows for dynamic, engaging assessments directly within lesson content, providing immediate and actionable feedback to users. The changes involve the creation of a dedicated quiz component, styling adjustments, and updates to the content parsing logic to support Markdown within quiz elements, ensuring a more robust and user-friendly learning environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new interactive quiz component to the site. The changes include adding new SASS styles for the quiz, integrating it into the main stylesheet, and adjusting the translucency of a site-wide background color. The quiz component is registered for both client-side and server-side rendering, and its content model now supports Markdown for questions, options, and explanations, with answer options being shuffled. Existing plain text quizzes in various tutorial Markdown files have been converted to use this new interactive quiz component. Review comments suggest replacing hardcoded green and red colors for correct/incorrect answer text in the quiz styles with site-wide theme variables (--site-alert-tip-color and --site-alert-error-color) to ensure visual consistency and proper theming.
ericwindmill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that some of the questions could be improved. But we should just land something functional for now. Regardless of how well we write them right now, I'll end up editing them when I do my final pass
These questions are a bit rough and definitely could use some improvements, but I wanted to get some relevant content down and functional. Please do make changes in this PR or in follow-up PRs.