-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt implicit cast example for type system page #6478
Conversation
Visit the preview URL for this PR (updated for commit 32cb124): https://dart-dev--pr6478-feat-type-system-implicit-casts-j5bzqnf7.web.app |
Thank you for adding that staged link! A dream: we have those created by default when we stage. ^_^ |
@eernstg, adding you as our technical reviewer. Can you double-check the staged doc? If you want to triage this to another technical expert, please do so. Note to Dart engineers: on reviews where any doc changes are added that modify technical content, we generally need to make sure we have at least one technical writer and one additional engineer on those PRs for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a programming language perspective. I recommended a couple of simplifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR looks great. Once @eernstg's changes are added, it'll be ready to launch!
Co-authored-by: Erik Ernst <[email protected]>
Thanks for the great feedback @eernstg! It does make a lot more sense to keep it focused on a simple downcast example. I applied your suggested changes and updated the section title to be more explicit as you suggested ("Implicit downcasts from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to make sure I'm not blocking you. LGTM ^_^
Adds a section about implicit cast runtime errors to the "Type system" page, based off the Invalid casts section of the deprecated sound problems page.
Contributes to #6265
Staged: https://dart-dev--pr6478-feat-type-system-implicit-casts-j5bzqnf7.web.app/language/type-system#implicit-casts