Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt implicit cast example for type system page #6478

Merged
merged 5 commits into from
Mar 11, 2025

Conversation

parlough
Copy link
Member

@parlough parlough commented Mar 7, 2025

Adds a section about implicit cast runtime errors to the "Type system" page, based off the Invalid casts section of the deprecated sound problems page.

Contributes to #6265

Staged: https://dart-dev--pr6478-feat-type-system-implicit-casts-j5bzqnf7.web.app/language/type-system#implicit-casts

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Mar 7, 2025

Visit the preview URL for this PR (updated for commit 32cb124):

https://dart-dev--pr6478-feat-type-system-implicit-casts-j5bzqnf7.web.app

@parlough parlough requested a review from antfitch March 7, 2025 19:13
@antfitch
Copy link
Collaborator

antfitch commented Mar 7, 2025

Thank you for adding that staged link! A dream: we have those created by default when we stage. ^_^

@antfitch antfitch requested a review from eernstg March 7, 2025 19:20
@antfitch
Copy link
Collaborator

antfitch commented Mar 7, 2025

@eernstg, adding you as our technical reviewer. Can you double-check the staged doc? If you want to triage this to another technical expert, please do so.

Note to Dart engineers: on reviews where any doc changes are added that modify technical content, we generally need to make sure we have at least one technical writer and one additional engineer on those PRs for review.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a programming language perspective. I recommended a couple of simplifications.

Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR looks great. Once @eernstg's changes are added, it'll be ready to launch!

@parlough
Copy link
Member Author

Thanks for the great feedback @eernstg! It does make a lot more sense to keep it focused on a simple downcast example. I applied your suggested changes and updated the section title to be more explicit as you suggested ("Implicit downcasts from dynamic").

@parlough parlough requested a review from antfitch March 10, 2025 23:26
Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to make sure I'm not blocking you. LGTM ^_^

@parlough parlough merged commit 1b97792 into main Mar 11, 2025
10 checks passed
@parlough parlough deleted the feat/type-system-implicit-casts branch March 11, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants