Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention new pub publish warning in "Publishing packages" #6247

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

MaryaBelanger
Copy link
Contributor

Fixes #6232 (fixed some random typos too)

Some outstanding questions: dart-lang/pub#4373 (comment)

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Dec 2, 2024

Visit the preview URL for this PR (updated for commit 66cbd44):

https://dart-dev--pr6247-pub-publish-vejf8m6s.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Marya!

One small suggestion to consider:

src/content/tools/pub/publishing.md Outdated Show resolved Hide resolved
@MaryaBelanger
Copy link
Contributor Author

I'm going to merge this for now, but really hoping to update it with #6246 once I get more info on validations

@MaryaBelanger MaryaBelanger merged commit 559bdaa into main Dec 6, 2024
10 checks passed
@MaryaBelanger MaryaBelanger deleted the pub-publish branch December 6, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note that dart pub publish will warn about your repo having uncommitted changes
3 participants