Skip to content

[native_assets_cli] Prevent non src imports from src #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 24, 2025

This PR removes all imports of the lib/foo.dart files in lib/src/**.dart.

These imports are unwanted as they are a blanket import. Instead, the file with the actual definitions in src/ should be imported.

Bug:

Before we can address #999, we need to have an idea what the import structure should look like.

Copy link

github-actions bot commented Apr 24, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_builder Non-Breaking 0.17.0 0.18.0-wip 0.17.1 ✔️
native_assets_cli Breaking 0.17.0 0.18.0-wip 0.18.0 ✔️
native_toolchain_c Non-Breaking 0.14.0 0.15.0-wip 0.14.1 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Apr 24, 2025

Coverage Status

coverage: 78.421%. remained the same
when pulling f0ec45c on organize-imports-3
into dcc6fc9 on main.

@dcharkes dcharkes requested a review from goderbauer April 24, 2025 15:22
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for your lint rules as well?

@dcharkes
Copy link
Collaborator Author

Can you add tests for your lint rules as well?

Done. I can't add it in the same package though. (Custom lints apparently can't be applied to their own package.)

@dcharkes dcharkes requested a review from HosseinYousefi April 24, 2025 19:08
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcharkes dcharkes merged commit 40e0a3c into main Apr 25, 2025
30 checks passed
@dcharkes dcharkes deleted the organize-imports-3 branch April 25, 2025 07:20
@dcharkes
Copy link
Collaborator Author

Thanks @HosseinYousefi 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants