-
Notifications
You must be signed in to change notification settings - Fork 68
[native_assets_cli] Prevent non src imports from src #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for your lint rules as well?
Done. I can't add it in the same package though. (Custom lints apparently can't be applied to their own package.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @HosseinYousefi 🙏 |
This PR removes all imports of the
lib/foo.dart
files inlib/src/**.dart
.These imports are unwanted as they are a blanket import. Instead, the file with the actual definitions in
src/
should be imported.Bug:
Before we can address #999, we need to have an idea what the import structure should look like.