Skip to content

[infra] Create a pub workspace #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

[infra] Create a pub workspace #2178

merged 1 commit into from
Apr 8, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 7, 2025

Bug:

Split off:

🙏 @Levi-Lesches !

Included packages:

  • pkgs/code_assets
  • pkgs/data_assets
  • pkgs/hooks
  • pkgs/json_syntax_generator
  • pkgs/native_assets_builder
  • pkgs/native_assets_cli
  • pkgs/native_toolchain_c

These packages are developed in lock-step, and might want a dev release as lower bound. (FFIgen, JNIgen, etc. probably want to always have a stable SDK as lower bound.)

This PR is the minimal PR to enable pub workspaces. It enables single package resolution in the workspace, but does not clean anything up: the path dependencies are not removed yet. We should be able to remove these and simply refer to the WIP versions.

Copy link

github-actions bot commented Apr 7, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the native-workspace branch 3 times, most recently from e40beb3 to b34a714 Compare April 7, 2025 19:30
@dcharkes dcharkes marked this pull request as ready for review April 7, 2025 20:28
@dcharkes dcharkes requested a review from mosuem April 7, 2025 20:28
@dcharkes dcharkes merged commit b45d842 into main Apr 8, 2025
39 checks passed
@dcharkes dcharkes deleted the native-workspace branch April 8, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants