-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the sunflower sample to perform better at various sizes #2836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! This is nice and ends up looking better in both a constrained and wider environment.
One optional consideration to consider:
Could you add some spacing after(below) the slider? It felt a bit cramped interacting with it so close to the bottom, and it might feel even more so on mobile.
Also note that you'll need to update this PR and regenerate since cff1de0 landed. |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ptal again - I updated the sample w/ improved padding and to better match modern best practices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me! Thanks for the adjustments.
Maybe we should just drop the drawer? I'm not sure what it's adding in relation to the current focus of the sample. We can show that off in some other sample where it fits better contextually.
We don't need the drawer, we added it a long time ago to prove that this was a Flutter app and not an HTML app |
Gotcha - will take out the drawer. |
done! The sample's just over 100 lines of code now; I think if we wanted to we could get it down to ~100. |
Previously, this sample would overflow if the containing area was not tall enough.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.