Skip to content

Fixes #3363. Hide extensions when import is deferred #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

Fixes #3363. Hide extensions when import is deferred #3365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions LanguageFeatures/Parts-with-imports/resolving_extensions_A01_t01.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
/// @description Check that an extension declared in a part file is available in
/// its parent file and vice versa.
/// @author [email protected]
/// @issue 61804

// SharedOptions=--enable-experiment=enhanced-parts

Expand Down
1 change: 1 addition & 0 deletions LanguageFeatures/Parts-with-imports/resolving_extensions_A01_t01_part1.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
/// @description Check that an extension declared in a part file is available in
/// its parent file and vice versa.
/// @author [email protected]
/// @issue 61804

// SharedOptions=--enable-experiment=enhanced-parts

Expand Down
1 change: 1 addition & 0 deletions LanguageFeatures/Parts-with-imports/resolving_extensions_A01_t01_part2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
/// @description Check that an extension declared in a part file is available in
/// its parent file and vice versa.
/// @author [email protected]
/// @issue 61804

// SharedOptions=--enable-experiment=enhanced-parts

Expand Down
1 change: 1 addition & 0 deletions LanguageFeatures/Parts-with-imports/resolving_extensions_A01_t03.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
/// @description Check that an extension available by import in a part file is
/// available in its parts but not available in the parent.
/// @author [email protected]
/// @issue 61805

// SharedOptions=--enable-experiment=enhanced-parts

Expand Down
1 change: 1 addition & 0 deletions LanguageFeatures/Parts-with-imports/resolving_extensions_A01_t03_part1.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
/// @description Check that an extension available by import in a part file is
/// available in its parts.
/// @author [email protected]
/// @issue 61805

// SharedOptions=--enable-experiment=enhanced-parts

Expand Down
1 change: 1 addition & 0 deletions LanguageFeatures/Parts-with-imports/resolving_extensions_A01_t03_part2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
/// @description Check that an extension available by import in a part file is
/// available in its parts.
/// @author [email protected]
/// @issue 61805

// SharedOptions=--enable-experiment=enhanced-parts

Expand Down
1 change: 1 addition & 0 deletions LanguageFeatures/Parts-with-imports/scope_A06_t02.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
/// @description Check that a part file can use the same deferred import prefix
/// as a prefix that it inherits. In this case it shadows inherited declarations
/// @author [email protected]
/// @issue 61806

// SharedOptions=--enable-experiment=enhanced-parts

Expand Down
4 changes: 2 additions & 2 deletions LanguageFeatures/Parts-with-imports/scope_A06_t02_part1.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@
/// @description Check that a part file can use the same deferred import prefix
/// as a prefix that it inherits. In this case it shadows inherited declarations
/// @author [email protected]
/// @issue 61806

// SharedOptions=--enable-experiment=enhanced-parts

part of 'scope_A06_t02.dart';

import 'parts_lib.dart' deferred as l;
import 'parts_lib.dart' deferred as l hide LibExt;

part 'scope_A06_t02_part2.dart';

Expand All @@ -42,6 +43,5 @@ testPart1() async {
Expect.equals("LibClass", l.LibClass.id);
Expect.equals("LibMixin", l.LibMixin.id);
Expect.equals("LibEnum", l.LibEnum.id);
Expect.equals("LibExt", l.LibExt.id);
Expect.equals("LibET", l.LibET.id);
}
4 changes: 2 additions & 2 deletions LanguageFeatures/Parts-with-imports/scope_A06_t02_part2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@
/// @description Check that a part file can use the same deferred import prefix
/// as a prefix that it inherits. In this case it shadows inherited declarations
/// @author [email protected]
/// @issue 61806

// SharedOptions=--enable-experiment=enhanced-parts

part of 'scope_A06_t02_part1.dart';

import 'scope_lib1.dart' deferred as l;
import 'scope_lib1.dart' deferred as l hide LibExt;

testPart2() async {
await l.loadLibrary();
Expand All @@ -40,7 +41,6 @@ testPart2() async {
Expect.equals("scope_lib1 LibClass", l.LibClass.id);
Expect.equals("scope_lib1 LibMixin", l.LibMixin.id);
Expect.equals("scope_lib1 LibEnum", l.LibEnum.id);
Expect.equals("scope_lib1 LibExt", l.LibExt.id);
Expect.equals("scope_lib1 LibET", l.LibET.id);
// From parts_lib.dart
Expect.equals(0, l.counter);
Expand Down
2 changes: 1 addition & 1 deletion LanguageFeatures/Parts-with-imports/scope_A06_t03_part2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

part of 'scope_A06_t03_part1.dart';

import 'scope_lib1.dart' deferred as l;
import 'scope_lib1.dart' deferred as l hide LibExt;

testPart2() async {
// From scope_lib1.dart
Expand Down