Skip to content

Conversation

@sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, handful of typos plus description nits.

Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Updated. PTAL.

@sgrekhov sgrekhov requested a review from eernstg October 28, 2025 13:02
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 2f88cd8 into dart-lang:master Oct 29, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 3, 2025
2025-10-31 [email protected] Fixes dart-lang/co19#3378. Add an error for the analyzer in definition_t16.dart (dart-lang/co19#3379)
2025-10-30 [email protected] dart-lang/co19#3329. Add more private named parameters tests (dart-lang/co19#3375)
2025-10-30 [email protected] Update ffi package version (dart-lang/co19#3376)
2025-10-29 [email protected] dart-lang/co19#3329. Add tests for "corresponding public name" (dart-lang/co19#3361)
2025-10-29 [email protected] Fixes dart-lang/co19#3373. Fix constructor invocation in definition_t16.dart (dart-lang/co19#3374)
2025-10-29 [email protected] dart-lang/co19#3329. Add private named parameters tests. (dart-lang/co19#3362)
2025-10-29 [email protected] dart-lang/co19#2825. Add sanity rules tests (dart-lang/co19#3370)
2025-10-29 [email protected] Fixes dart-lang/co19#3371. Remove obsolete test Language/Classes/definition_t14.dart (dart-lang/co19#3372)

[email protected], [email protected]

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I7326b0aacf83a64a5f89dc6a22da836af6961a93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459260
Reviewed-by: Erik Ernst <[email protected]>
Auto-Submit: Sergey Grekhov <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants