Skip to content

#3329. Add tests for "corresponding public name" #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 29, 2025
Merged

#3329. Add tests for "corresponding public name" #3361

merged 6 commits into from
Oct 29, 2025

Conversation

@sgrekhov
Copy link
Contributor

No description provided.

eernstg
eernstg reviewed Oct 27, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments added.

@sgrekhov sgrekhov requested a review from eernstg October 28, 2025 13:04
sgrekhov
sgrekhov commented Oct 28, 2025
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Updated. PTAL.

eernstg
eernstg reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a couple of comments.

sgrekhov
sgrekhov commented Oct 29, 2025
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Updated. PTAL.

@sgrekhov sgrekhov requested a review from eernstg October 29, 2025 14:56
eernstg
eernstg approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 2592c1c into dart-lang:master Oct 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgrekhov @eernstg