Skip to content

fix: correctly apply timeouts across implementations #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2024
Merged

fix: correctly apply timeouts across implementations #10

merged 1 commit into from
Dec 8, 2024

Conversation

dignifiedquire
Copy link

@dignifiedquire dignifiedquire commented Nov 1, 2024 •
edited
Loading

These were broken in 0.15 unfortunately.

I have added single_search_timeout to the options, to be able to control a single search, as well as applying the overall timeout consistently now.

Ref n0-computer/iroh#2876

divagant-martian
divagant-martian approved these changes Nov 1, 2024
View reviewed changes
Copy link

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! the sync version might produce some zero durations at some points but at worst that will produce SearchErrors of a different kind. In any case this still fixes the buggy behaviour

dariusc93
dariusc93 approved these changes Dec 8, 2024
View reviewed changes
Copy link
Owner

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Sorry for being late to checking this out!

@dariusc93 dariusc93 merged commit b6d1542 into dariusc93:master Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@divagant-martian divagant-martian divagant-martian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dignifiedquire @dariusc93 @divagant-martian