Fix incorrect grouping when identical text nodes occur#36
Open
nquenouille wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When processing continued elements, tag spans could extend too far if identical text content appeared multiple times (e.g. repeated words).
Cause: The code used index-of(current-group(), $final) to determine the position of a node within a group.
However, index-of() compares atomic values, not node identity.
As a result, multiple nodes with identical string values were treated as equal, and the last matching position was selected.
Solution: Replaced the index-of()-based lookup with a node identity comparison using "is", ensuring that the correct node instance is selected even when text content is identical.
Result:
This change avoids value-based comparison for node sequences and ensures consistent behavior when duplicate text nodes are present.
With many thanks!