chore: add possibility to create actors without the implementation #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Geerinck <[email protected]>
Signed-off-by: Xavier Geerinck <[email protected]>
Signed-off-by: Xavier Geerinck <[email protected]>
Signed-off-by: Xavier Geerinck <[email protected]>
Signed-off-by: Xavier Geerinck <[email protected]>
Signed-off-by: Xavier Geerinck <[email protected]>
Signed-off-by: Xavier Geerinck <[email protected]>
Signed-off-by: Xavier Geerinck <[email protected]>
|
At first glance, this appears to implement a breaking change as anyone currently using actors would have to rebuild their applications to support this. Is that intentional? |
Signed-off-by: Xavier Geerinck <[email protected]>
|
Added backwards-compatibility for the breaking change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Long overdue, this PR solves the issue that when you are creating an Actor Proxy, that the implementation of the actor was required. There was a work around for it, but this PR makes it more concrete.
This PR also adds the possibility to use an interface class name that differs from the registered actor.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #417
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: