Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for docker install instead of actions-setup-docker #986

Merged
merged 2 commits into from
May 31, 2022

Conversation

pravinpushkar
Copy link
Contributor

Signed-off-by: Pravin Pushkar [email protected]

Description

Switching to brew install instead of using actions-setup-docker github action, as with the action docker setup seems highly unstable. This way it might increase the time to setup docker on macos (can take upto 10 mins) but atleast it looks more stable. It failed once in last 4 runs. See here- https://github.com/pravinpushkar/cli/actions/workflows/self_hosted_e2e.yaml

Related discussions can be found here - docker/for-mac#2359

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #981

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@pravinpushkar pravinpushkar requested review from a team as code owners May 23, 2022 14:21
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #986 (95f546d) into master (0c51481) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   21.71%   21.71%           
=======================================
  Files          33       33           
  Lines        1920     1920           
=======================================
  Hits          417      417           
  Misses       1449     1449           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c51481...95f546d. Read the comment docs.

Signed-off-by: Pravin Pushkar <[email protected]>
Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on docker/for-mac#2359 (comment) and our testing with quickstarts/pipelines.

@mukundansundar mukundansundar merged commit 3d2e0b8 into dapr:master May 31, 2022
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jun 3, 2022
* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <[email protected]>

* trigger pr checks

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: HueiFeng <[email protected]>
mukundansundar pushed a commit that referenced this pull request Jun 9, 2022
* Modify path DaprRoot add the SystemDrive environment variable

Signed-off-by: HueiFeng <[email protected]>

* Script for docker install instead of actions-setup-docker (#986)

* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <[email protected]>

* trigger pr checks

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Format output of dapr --version as JSON.  (#878)

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <[email protected]>

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Fix for panic during upgrade of edge version dapr (#983)

* Fix for panic during upgrade of edge version dapr

Signed-off-by: Pravin Pushkar <[email protected]>

* change console log message

Signed-off-by: Pravin Pushkar <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Add dapr annotate command (#873)

* Add dapr inject command

Signed-off-by: Joni Collinge <[email protected]>

* Add additional opts

Signed-off-by: Joni Collinge <[email protected]>

* Update comment regarding injection

Signed-off-by: Joni Collinge <[email protected]>

* fix some linting issues (more to go)

Signed-off-by: Joni Collinge <[email protected]>

* use existing const in tests

Signed-off-by: Joni Collinge <[email protected]>

* fix some more linting

Signed-off-by: Joni Collinge <[email protected]>

* fix some more linting

Signed-off-by: Joni Collinge <[email protected]>

* udpate tests

Signed-off-by: Joni Collinge <[email protected]>

* udpate tests

Signed-off-by: Joni Collinge <[email protected]>

* add option to run against a URL

Signed-off-by: Joni Collinge <[email protected]>

* refactor cmd/inject.go slightly

Signed-off-by: Joni Collinge <[email protected]>

* update example text

Signed-off-by: Joni Collinge <[email protected]>

* autogenerate appid if not present

Signed-off-by: Joni Collinge <[email protected]>

* Update comment

Signed-off-by: Joni Collinge <[email protected]>

* Add support for target namespace

Signed-off-by: Joni Collinge <[email protected]>

* Update comment

Signed-off-by: Joni Collinge <[email protected]>

* Add warning about app id generation to usage

Signed-off-by: Joni Collinge <[email protected]>

* fix linting issues

Signed-off-by: Joni Collinge <[email protected]>

* rename inject to annotate

Signed-off-by: Joni Collinge <[email protected]>

* go mod tidy

Signed-off-by: Joni Collinge <[email protected]>

* fix lint

Signed-off-by: Joni Collinge <[email protected]>

* update --help URL

Signed-off-by: Joni Collinge <[email protected]>

* add README.md seciton

Signed-off-by: Joni Collinge <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Update go version to 1.18 (#982)

* Update go version to 1.18

Signed-off-by: Pravin Pushkar <[email protected]>

* Bumping golangci-lint

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* adding dapr-http-read-buffer-size parameter to cli

Signed-off-by: HueiFeng <[email protected]>

Co-authored-by: Pravin Pushkar <[email protected]>
Co-authored-by: FanBin <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Joni Collinge <[email protected]>
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jul 18, 2022
* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <[email protected]>

* trigger pr checks

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: hueifeng <[email protected]>
hueifeng added a commit to hueifeng/cli that referenced this pull request Jul 18, 2022
* Modify path DaprRoot add the SystemDrive environment variable

Signed-off-by: HueiFeng <[email protected]>

* Script for docker install instead of actions-setup-docker (dapr#986)

* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <[email protected]>

* trigger pr checks

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Format output of dapr --version as JSON.  (dapr#878)

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <[email protected]>

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Fix for panic during upgrade of edge version dapr (dapr#983)

* Fix for panic during upgrade of edge version dapr

Signed-off-by: Pravin Pushkar <[email protected]>

* change console log message

Signed-off-by: Pravin Pushkar <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Add dapr annotate command (dapr#873)

* Add dapr inject command

Signed-off-by: Joni Collinge <[email protected]>

* Add additional opts

Signed-off-by: Joni Collinge <[email protected]>

* Update comment regarding injection

Signed-off-by: Joni Collinge <[email protected]>

* fix some linting issues (more to go)

Signed-off-by: Joni Collinge <[email protected]>

* use existing const in tests

Signed-off-by: Joni Collinge <[email protected]>

* fix some more linting

Signed-off-by: Joni Collinge <[email protected]>

* fix some more linting

Signed-off-by: Joni Collinge <[email protected]>

* udpate tests

Signed-off-by: Joni Collinge <[email protected]>

* udpate tests

Signed-off-by: Joni Collinge <[email protected]>

* add option to run against a URL

Signed-off-by: Joni Collinge <[email protected]>

* refactor cmd/inject.go slightly

Signed-off-by: Joni Collinge <[email protected]>

* update example text

Signed-off-by: Joni Collinge <[email protected]>

* autogenerate appid if not present

Signed-off-by: Joni Collinge <[email protected]>

* Update comment

Signed-off-by: Joni Collinge <[email protected]>

* Add support for target namespace

Signed-off-by: Joni Collinge <[email protected]>

* Update comment

Signed-off-by: Joni Collinge <[email protected]>

* Add warning about app id generation to usage

Signed-off-by: Joni Collinge <[email protected]>

* fix linting issues

Signed-off-by: Joni Collinge <[email protected]>

* rename inject to annotate

Signed-off-by: Joni Collinge <[email protected]>

* go mod tidy

Signed-off-by: Joni Collinge <[email protected]>

* fix lint

Signed-off-by: Joni Collinge <[email protected]>

* update --help URL

Signed-off-by: Joni Collinge <[email protected]>

* add README.md seciton

Signed-off-by: Joni Collinge <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Update go version to 1.18 (dapr#982)

* Update go version to 1.18

Signed-off-by: Pravin Pushkar <[email protected]>

* Bumping golangci-lint

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* adding dapr-http-read-buffer-size parameter to cli

Signed-off-by: HueiFeng <[email protected]>

Co-authored-by: Pravin Pushkar <[email protected]>
Co-authored-by: FanBin <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Joni Collinge <[email protected]>
Signed-off-by: hueifeng <[email protected]>
hueifeng pushed a commit to hueifeng/cli that referenced this pull request Jul 29, 2022
* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <[email protected]>

* trigger pr checks

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: hueifeng <[email protected]>
hueifeng added a commit to hueifeng/cli that referenced this pull request Jul 29, 2022
* Modify path DaprRoot add the SystemDrive environment variable

Signed-off-by: HueiFeng <[email protected]>

* Script for docker install instead of actions-setup-docker (dapr#986)

* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <[email protected]>

* trigger pr checks

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Format output of dapr --version as JSON.  (dapr#878)

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <[email protected]>

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Fix for panic during upgrade of edge version dapr (dapr#983)

* Fix for panic during upgrade of edge version dapr

Signed-off-by: Pravin Pushkar <[email protected]>

* change console log message

Signed-off-by: Pravin Pushkar <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Add dapr annotate command (dapr#873)

* Add dapr inject command

Signed-off-by: Joni Collinge <[email protected]>

* Add additional opts

Signed-off-by: Joni Collinge <[email protected]>

* Update comment regarding injection

Signed-off-by: Joni Collinge <[email protected]>

* fix some linting issues (more to go)

Signed-off-by: Joni Collinge <[email protected]>

* use existing const in tests

Signed-off-by: Joni Collinge <[email protected]>

* fix some more linting

Signed-off-by: Joni Collinge <[email protected]>

* fix some more linting

Signed-off-by: Joni Collinge <[email protected]>

* udpate tests

Signed-off-by: Joni Collinge <[email protected]>

* udpate tests

Signed-off-by: Joni Collinge <[email protected]>

* add option to run against a URL

Signed-off-by: Joni Collinge <[email protected]>

* refactor cmd/inject.go slightly

Signed-off-by: Joni Collinge <[email protected]>

* update example text

Signed-off-by: Joni Collinge <[email protected]>

* autogenerate appid if not present

Signed-off-by: Joni Collinge <[email protected]>

* Update comment

Signed-off-by: Joni Collinge <[email protected]>

* Add support for target namespace

Signed-off-by: Joni Collinge <[email protected]>

* Update comment

Signed-off-by: Joni Collinge <[email protected]>

* Add warning about app id generation to usage

Signed-off-by: Joni Collinge <[email protected]>

* fix linting issues

Signed-off-by: Joni Collinge <[email protected]>

* rename inject to annotate

Signed-off-by: Joni Collinge <[email protected]>

* go mod tidy

Signed-off-by: Joni Collinge <[email protected]>

* fix lint

Signed-off-by: Joni Collinge <[email protected]>

* update --help URL

Signed-off-by: Joni Collinge <[email protected]>

* add README.md seciton

Signed-off-by: Joni Collinge <[email protected]>

Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* Update go version to 1.18 (dapr#982)

* Update go version to 1.18

Signed-off-by: Pravin Pushkar <[email protected]>

* Bumping golangci-lint

Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: HueiFeng <[email protected]>

* adding dapr-http-read-buffer-size parameter to cli

Signed-off-by: HueiFeng <[email protected]>

Co-authored-by: Pravin Pushkar <[email protected]>
Co-authored-by: FanBin <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Joni Collinge <[email protected]>
Signed-off-by: hueifeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow for E2E - self hosted is not stable on MacOS - darwin
3 participants