Skip to content

dapp verify-contract updates/fixes #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

brianmcmichael
Copy link
Contributor

Etherscan verification with dapptools does not appear to be working at the moment. This PR updates the dapp-create and dapp-verify scripts to successfully verify a contract at etherscan.

Notable Changes:

  • In dapp-create, pass the path of the code, instead of the class name, to dapp-verify
  • Add leading v to version string to match etherscan list
  • Get the list of available compilers from etherscan and compare with the build compiler, due to occasional discrepancies between the C solc release and the JS solc release, we add a block of code to select the best option from the list of available etherscan-compatible compilers.
  • fixes bug in contract address string
  • cleans up some of the loops related to checking results, since there is always a delay between when the transaction is confirmed and when it is available for verification at etherscan, sleep timeout is moved to the beginning of retry loop so that it should succeed on the first try.
  • Similar handling of checkverify status. Loop was removed here as a design decision to keep the script moving, we can replace it if necessary.

@godsflaw
Copy link
Contributor

@livnev ^^^

@livnev livnev requested a review from rainbreak October 12, 2019 09:02
@livnev
Copy link
Member

livnev commented Oct 19, 2019

@brianmcmichael @godsflaw Thanks for the PR. This looks good and appears to work. Could you squash the commit history into one or more clean commits, to get rid of development artifacts, etc.?

@brianmcmichael
Copy link
Contributor Author

Hi @livnev

Sorry about the mess. You should be able to do this directly from the github UI.

squash

@livnev livnev mentioned this pull request Oct 19, 2019
@livnev livnev closed this Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants