chore: Restructure CI workflows to introduce a validation job#227
Conversation
- Added a new `validate` job in the CI workflow to handle installation, linting, type-checking, and circular dependency checks. - Updated the `publish` job to depend on the `validate` job, ensuring all validations are completed before publishing. - Removed redundant steps from the `publish` job, streamlining the workflow and improving maintainability. - Introduced a new `validate.yml` file to encapsulate validation logic, enhancing modularity and reusability across workflows.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f31e98d9f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: google_llm_tests | ||
| if: steps.google_changes.outputs.changed == 'true' | ||
| continue-on-error: true | ||
| run: npx jest src/llm/google/llm.spec.ts --runInBand |
There was a problem hiding this comment.
When this reusable workflow is reached from .github/workflows/publish.yml (publish now needs validate) and a Google LLM change is detected on main, this step no longer has the 5-minute timeout-minutes guard that the old publish job had. Because the step is intentionally soft-failed only after it exits, a hung provider/API test can now hold the publish and release path until the default Actions job timeout instead of surfacing quickly; please carry the publish timeout over here and to the other gated tests moved into validate.yml.
Useful? React with 👍 / 👎.
- Added a timeout of 6 minutes to the Google, Anthropic, PTC, and Tool Search unit test jobs in the CI workflow to prevent premature job termination during execution.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
validatejob in the CI workflow to handle installation, linting, type-checking, and circular dependency checks.publishjob to depend on thevalidatejob, ensuring all validations are completed before publishing.publishjob, streamlining the workflow and improving maintainability.validate.ymlfile to encapsulate validation logic, enhancing modularity and reusability across workflows.