Add missing __len__ impl to Mixture selector #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thanks for the great work!
Issue Description
Sampling with the
Mixture
selector results in an error due to missing__len__()
implementation.dreamerv3/embodied/core/replay.py
Line 123 in 55c8c67
PR Considerations
The implemented
__len__()
simply dispatches the call to the first selector. Reasoning:selector
is guaranteed to exist afterMixture.__init__()
:dreamerv3/embodied/core/selectors.py
Lines 202 to 210 in 55c8c67
len()
for eachselector
is identical because they have the same items:dreamerv3/embodied/core/selectors.py
Lines 217 to 223 in 55c8c67