Skip to content

Fix lines() cannot split big number #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
takyam-git wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix lines() cannot split big number #183

takyam-git wants to merge 1 commit into from

Conversation

@takyam-git
Copy link

@takyam-git takyam-git commented Apr 3, 2018 

>>> \Stringy\Stringy::create('111111111111111111111')->lines();
PHP Warning:  mb_split() expects parameter 3 to be integer, float given in /path/to/vendor/danielstjules/stringy/src/Stringy.php on line 1288

>>> echo 1111111111111111111111111111111
1.1111111111111E+30

Maybe split() 2nd argument does not need.

voku added a commit to voku/Stringy that referenced this pull request Aug 2, 2019
@voku
[+]: add more tests
e252bc8 
-> danielstjules#183

thanks @takyam-git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@takyam-git