-
Notifications
You must be signed in to change notification settings - Fork 0
Create a sign up page similar to sign in page #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@copilot clerk sign in and sign up urls set in the component props instead of env variables. remove from .env.example the ones that we don't need. |
Co-authored-by: danielpaul <[email protected]>
Co-authored-by: danielpaul <[email protected]>
I've updated the implementation to remove the unused Clerk environment variables from
Only kept Changes in commit 2b867c6. |
end | ||
end | ||
|
||
def create_signup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need create_signup. this does not do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the create_signup
method as it was unnecessary. Clerk handles authentication entirely on the frontend through the __session
cookie, so POST endpoints for token validation aren't part of the standard flow. Changes in commit 012a1d2.
end | ||
end | ||
|
||
def create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need create
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the create
method as it was unnecessary. The POST /sign_in endpoint isn't needed since Clerk manages authentication through its own frontend flow. Changes in commit 012a1d2.
@copilot work on the changes |
Co-authored-by: danielpaul <[email protected]>
I've addressed the feedback by removing the unnecessary Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR implements a complete sign-up page that mirrors the existing sign-in functionality, providing users with a consistent authentication experience.
What's Added
New Sign-Up Page: Created
app/frontend/pages/sessions/sign_up.tsx
using Clerk's<SignUp>
component, following the same pattern as the existing sign-in page for consistency.Backend Routes & Controller: Added
GET /sign_up
route andsign_up
method inSessionsController
to handle the sign-up page rendering.Complete Test Coverage: Added comprehensive tests for the sign-up GET endpoint and existing Clerk authentication flow, ensuring proper authentication behavior.
Environment Variables Cleanup: Removed unused Clerk environment variables from
.env.example
since sign-in and sign-up URLs are set directly in component props instead of environment variables.Key Features
AuthLayout
and styling as the sign-in pageAuthentication Flow
The implementation follows Clerk's standard authentication pattern where:
__session
cookie that Clerk managesFiles Changed
config/routes.rb
- Added sign-up GET routeapp/controllers/sessions_controller.rb
- Added sign-up handling methodapp/frontend/pages/sessions/sign_up.tsx
- New sign-up page componentspec/requests/sessions_spec.rb
- Added comprehensive test coverage.env.example
- Removed unused Clerk environment variablesThe implementation maintains the existing authentication patterns while providing the requested sign-up functionality. All tests pass and the code follows the project's linting and formatting standards.
Fixes #26.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.