Skip to content

fix: add DOI to prefix_mapping in _get_not_found_ids #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lior-airis wants to merge 1 commit into from
Closed

fix: add DOI to prefix_mapping in _get_not_found_ids #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions semanticscholar/AsyncSemanticScholar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ def _get_not_found_ids(self, paper_ids, papers):

prefix_mapping = {
'ARXIV': 'ArXiv',
'DOI': 'DOI',
'MAG': 'MAG',
'ACL': 'ACL',
'PMID': 'PubMed',
Expand All @@ -241,11 +242,10 @@ def _get_not_found_ids(self, paper_ids, papers):
found_ids.add(paper.paperId)
if paper.externalIds:
for prefix, value in paper.externalIds.items():
found_ids.add(f'{value}')
if prefix.lower() in prefix_mapping:
found_ids.add(
f'{prefix_mapping[prefix.lower()]}:{value}')
else:
found_ids.add(f'{value}')
found_ids = {id.lower() for id in found_ids}

not_found_ids = [id for id in paper_ids if id.lower() not in found_ids]
Expand Down
26 changes: 25 additions & 1 deletion tests/test_semanticscholar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,18 @@ def test_get_papers_return_not_found(self):
self.assertEqual(len(not_found), 1)
self.assertEqual(not_found[0], 'CorpusId:211530585')

def test_get_papers_doi_prefix_not_false_positive(self):
paper = Paper({
'paperId': 'abc123',
'externalIds': {
'DOI': '10.1145/792550.792552',
'CorpusId': 12345
}
})
not_found = self.sch._AsyncSemanticScholar._get_not_found_ids(
['DOI:10.1145/792550.792552'], [paper])
self.assertEqual(not_found, [])

@test_vcr.use_cassette
def test_get_paper_authors(self):
data = self.sch.get_paper_authors('10.2139/ssrn.2250500')
Expand Down Expand Up @@ -829,7 +841,19 @@ async def test_get_papers_return_not_found_async(self):
not_found = data[1]
self.assertEqual(len(not_found), 1)
self.assertEqual(not_found[0], 'CorpusId:211530585')


def test_get_papers_doi_prefix_not_false_positive_async(self):
paper = Paper({
'paperId': 'abc123',
'externalIds': {
'DOI': '10.1145/792550.792552',
'CorpusId': 12345
}
})
not_found = self.sch._get_not_found_ids(
['DOI:10.1145/792550.792552'], [paper])
self.assertEqual(not_found, [])

@test_vcr.use_cassette
async def test_get_paper_authors_async(self):
data = await self.sch.get_paper_authors('10.2139/ssrn.2250500')
Expand Down
Loading