Skip to content

fix(install): resolve binaries with Bun.which so Windows stops reporting bun, git and claude missing #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Simonvm9114 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(install): resolve binaries with Bun.which so Windows stops reporting bun, git and claude missing #2297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions LifeOS/Tools/InstallEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,21 @@ function tryExec(cmd: string): string | null {
}
}

/**
* Absolute path of a binary on PATH, or null. Never `command -v` through
* tryExec on Windows: execSync runs cmd.exe there, which has no `command`
* built-in, so every probe failed and DetectEnv reported bun, git and the
* harness binary missing while running on bun (public issue #2295).
* Bun.which is cross-platform and PATHEXT-aware (finds npm's claude.cmd);
* the shell probes are the fallback when this file runs outside bun.
*/
function findBin(name: string): string | null {
const bun = (globalThis as { Bun?: { which(bin: string): string | null } }).Bun;
if (bun) return bun.which(name);
const out = tryExec(process.platform === "win32" ? `where ${name}` : `command -v ${name}`);
return out ? out.split(/\r?\n/)[0] : null;
}

export function detectOS(): OsInfo {
const platform: Platform =
process.platform === "darwin" ? "darwin" : process.platform === "win32" ? "windows" : "linux";
Expand All @@ -109,7 +124,7 @@ export function detectOS(): OsInfo {
}

export function detectTool(name: string, versionCmd: string): ToolInfo {
const path = tryExec(`command -v ${name}`);
const path = findBin(name);
if (!path) return { installed: false };
const out = tryExec(versionCmd);
const m = out?.match(/(\d+\.\d+[.\d]*)/);
Expand All @@ -133,7 +148,7 @@ export function detectHarness(home: string): HarnessInfo {
{ name: "cursor", root: join(home, ".cursor"), skills: "skills", bin: "cursor" },
{ name: "openclaw", root: join(home, ".openclaw"), skills: "skills", bin: "openclaw" },
];
const hasBin = (c: (typeof candidates)[number]) => !!tryExec(`command -v ${c.bin}`);
const hasBin = (c: (typeof candidates)[number]) => !!findBin(c.bin);
const info = (c: (typeof candidates)[number], confidence: HarnessInfo["confidence"]): HarnessInfo => ({
name: c.name,
configRoot: c.root,
Expand Down
4 changes: 3 additions & 1 deletion LifeOS/install/LIFEOS/TOOLS/ClipSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ async function run(cmd: string[], label: string): Promise<string> {
}

function requireBinary(bin: string, why: string): void {
const found = Bun.spawnSync(["which", bin]).exitCode === 0;
// Bun.which, not a spawned `which`: Windows has no which.exe outside Git Bash,
// so spawnSync threw ENOENT with ffmpeg installed (public issue #2295).
const found = Bun.which(bin) !== null;
if (!found) die(`${bin} not installed — needed to ${why}. brew install ${bin}`);
}

Expand Down
19 changes: 17 additions & 2 deletions LifeOS/install/skills/LifeOS/Tools/InstallEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,21 @@ function tryExec(cmd: string): string | null {
}
}

/**
* Absolute path of a binary on PATH, or null. Never `command -v` through
* tryExec on Windows: execSync runs cmd.exe there, which has no `command`
* built-in, so every probe failed and DetectEnv reported bun, git and the
* harness binary missing while running on bun (public issue #2295).
* Bun.which is cross-platform and PATHEXT-aware (finds npm's claude.cmd);
* the shell probes are the fallback when this file runs outside bun.
*/
function findBin(name: string): string | null {
const bun = (globalThis as { Bun?: { which(bin: string): string | null } }).Bun;
if (bun) return bun.which(name);
const out = tryExec(process.platform === "win32" ? `where ${name}` : `command -v ${name}`);
return out ? out.split(/\r?\n/)[0] : null;
}

export function detectOS(): OsInfo {
const platform: Platform =
process.platform === "darwin" ? "darwin" : process.platform === "win32" ? "windows" : "linux";
Expand All @@ -109,7 +124,7 @@ export function detectOS(): OsInfo {
}

export function detectTool(name: string, versionCmd: string): ToolInfo {
const path = tryExec(`command -v ${name}`);
const path = findBin(name);
if (!path) return { installed: false };
const out = tryExec(versionCmd);
const m = out?.match(/(\d+\.\d+[.\d]*)/);
Expand All @@ -133,7 +148,7 @@ export function detectHarness(home: string): HarnessInfo {
{ name: "cursor", root: join(home, ".cursor"), skills: "skills", bin: "cursor" },
{ name: "openclaw", root: join(home, ".openclaw"), skills: "skills", bin: "openclaw" },
];
const hasBin = (c: (typeof candidates)[number]) => !!tryExec(`command -v ${c.bin}`);
const hasBin = (c: (typeof candidates)[number]) => !!findBin(c.bin);
const info = (c: (typeof candidates)[number], confidence: HarnessInfo["confidence"]): HarnessInfo => ({
name: c.name,
configRoot: c.root,
Expand Down