Have the Makefile handle the MozJPEG dependency if it's not on the user's system. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clean` removes build files created by the managed source. `fullclean` does that AND removes external dependencies.
…cannot be declared as a dependency.
ozcoder
reviewed
Jun 25, 2019
Makefile
Outdated
| $(LIBJPEG): src/mozjpeg | ||
| ifeq ($(OS),Unixy) | ||
| cd $< && \ | ||
| $(AUTORECONF) -fiv && \ |
There was a problem hiding this comment.
This will no longer work :(
You need to use cmake to build mozjpeg now.
Something similar to this
mkdir build && cd build && cmake -G"Unix Makefiles" ../ -DCMAKE_INSTALL_PREFIX=/usr/local -DWITH_JPEG8=1 && make && make install/strip && ldconfig -n /usr/local/lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a convenience to users who don't have MozJPEG installed to have the Makefile download, configure, and compile the libjpeg.a dependency. As a result, the AppVeyor and Travis-CI scripts are simpler as are the instructions in the README.
The MozJPEG process is broken out into two include files. The first one tries to find MozJPEG on the user's system. If it finds it (or if the user provided the location of MOZJPEG_PREFIX), then the build process will be set up to use that.
If the script wasn't able to find MozJPEG, then the other include file is activated. This include provides all of the rules for downloading, configuring and building MozJPEG in the source.