Skip to content

URL encode the database name in the curl command #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bpbp-boop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

URL encode the database name in the curl command #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions couchdb-dump.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,18 @@ checkdiskspace(){
exit 1
fi
}

urlencode() {
local i c L=${#1}
for (( i=0; i<L; i++ )); do # loop characters, not bytes
c="${1:i:1}"
if [[ "$c" == [a-zA-Z0-9.~_-] ]]; then echo -n "$c"
else echo -n "$c" | hexdump -v -e '/1 "%02x"' | sed 's/\(..\)/%\1/g' # encode multiple bytes
fi
done
echo
}

## END FUNCTIONS

# Catch no args:
Expand Down Expand Up @@ -192,7 +204,7 @@ else
sed_cmd="sed";
fi
## Make sure it's installed
echo | $sed_cmd 's/a//' >/dev/null 2>&1
echo | $sed_cmd 's/a//' >/dev/null 2>&1
if [ ! $? = 0 ]; then
echo "... ERROR: please install $sed_cmd (gnu-sed) and ensure it is in your path"
exit 1
Expand Down Expand Up @@ -244,7 +256,7 @@ fi
if [ ! "`echo $url | egrep -c ":[0-9]*$"`" = "1" ]; then
# add it.
url="$url:$port"
fi
fi

# Check for empty user/pass and try reading in from Envvars
if [ "x$username" = "x" ]; then
Expand Down Expand Up @@ -321,7 +333,8 @@ if [ $backup = true ]&&[ $restore = false ]; then
fi

# Grab our data from couchdb
curl ${curlSilentOpt} ${curlopt} -X GET "$url/$db_name/_all_docs?include_docs=true&attachments=true" -o ${file_name}
url_encoded_db_name=$(urlencode "$db_name")
curl ${curlSilentOpt} ${curlopt} -X GET "$url/$url_encoded_db_name/_all_docs?include_docs=true&attachments=true" -o ${file_name}
# Check for curl errors
if [ ! $? = 0 ]; then
echo "... ERROR: Curl encountered an issue whilst dumping the database."
Expand Down Expand Up @@ -565,7 +578,7 @@ elif [ $restore = true ]&&[ $backup = false ]; then
# Count the design file (if it even exists)
DESIGNS="`wc -l ${design_file_name} 2>/dev/null | awk '{print$1}'`"
# If there's no design docs for import...
if [ "x$DESIGNS" = "x" ]||[ "$DESIGNS" = "0" ]; then
if [ "x$DESIGNS" = "x" ]||[ "$DESIGNS" = "0" ]; then
# Cleanup any null files
rm -f ${design_file_name} 2>/dev/null
$echoVerbose && echo "... INFO: No Design Documents found for import."
Expand Down