add :default_vault configuration
#61
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
It has been brought to my attention through our tooling that the classic schema when using
Cloak.Ectocreates compile-connected dependencies between the schema and the vault.Indeed, using
field :field, CustomTypecreates a compile dependency toCustomType,which, in this library's use case, has in turn a runtime dependency to
MyApp.Vault,creating a compile-connected dependency.
I tried to think of some ways to avoid this:
:polymorphic_embed, and makeCloak.Ectorequire to use its ownfieldmacro, but I couldn't really figureout how to make it work honestly 😶
config :cloak_ecto, default_vault: MyApp.Vaultin the configuration, so thatthe
CustomTypemodule does not have to reference theMyApp.Vaultmodule.That obviously does not cover the use-case where projects have multiple vaults...
I did a small PoC of the second option. I did not update the documentation, nor the
unit tests, as I'm just asking your opinion on this option.
Thanks in advance!