[JENKINS-62014] Add smoke test for env var filters #1
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
Aug 12, 2020
|
|
||
| @Issue("JENKINS-62014") | ||
| @Test public void envVarFilters() throws Exception { | ||
| EnvVarsFilterGlobalConfiguration.getAllActivatedGlobalRules().add(new RemoveSpecificVariablesFilter("FOO", "TODO: UNUSED")); |
Author
There was a problem hiding this comment.
I am pretty sure the value parameter in the constructor for RemoveSpecificVariablesFilter is unused and could be removed. It's not used in config.jelly either from what I can see.
Owner
There was a problem hiding this comment.
Good point, copy & paste leftovers from https://github.com/jenkinsci/generic-environment-filters-plugin/blob/05d03ec0f99eac8bb96dc5c6cad8fe52f0630b38/src/main/java/io/jenkins/plugins/generic_environment_filters/VariableContributingFilter.java#L44; will fix in a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds a basic smoke test to jenkinsci#137.