Modify handlerUpdate

dangvanthanh · Aug 20, 2018 · b028ab5 · b028ab5
1 parent c120b90
commit b028ab5
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 72 deletions.
diff --git a/README.md b/README.md
@@ -68,13 +68,14 @@ export default {
 
 ### Props
 
-| Name                    | Type       | Description                                                              |
-| ----------------------- | ---------- | ------------------------------------------------------------------------ |
-| `name`                  | `String`   | Name of instance ckedior. **Default: editor-1**                          |
-| `id`                    | `String`   | Id of instance ckedior. **Default: editor-1**                            |
-| `types`                 | `String`   | Types of ckedior. **Default: classic**                                   |
-| `config`                | `Object`   | All configuration of ckeditor. **Default: {}**                           |
-| `instanceReadyCallback` | `Function` | Optional function that will be attached to CKEditor instanceReady event. |
+| Name                    | Type       | Description                                                                  |
+| ----------------------- | ---------- | ---------------------------------------------------------------------------- |
+| `name`                  | `String`   | Name of instance ckedior. **Default: editor- **                              |
+| `id`                    | `String`   | Id of instance ckedior. **Default: editor-1**                                |
+| `types`                 | `String`   | Types of ckedior. **Default: classic**                                       |
+| `config`                | `Object`   | All configuration of ckeditor. **Default: {}**                               |
+| `instanceReadyCallback` | `Function` | Optional function that will be attached to CKEditor instanceReady event.     |
+| `readOnlyMode`          | `Boolean`  | Option setReadOnly editor initializes in the proper mode. **Default: false** |
 
 ## Build Setup
 
@@ -97,6 +98,7 @@ Thanks to:
 - [rlfscin](https://github.com/rlfscin)
 - [Renato Souza](https://github.com/renatosistemasvc)
 - [Fernando Morgenstern](https://github.com/fernandomm)
+- [Christoph-Wagner](https://github.com/Christoph-Wagner)
 
 ## License
 

diff --git a/dist/vue-ckeditor2.cjs.js b/dist/vue-ckeditor2.cjs.js
@@ -66,13 +66,15 @@ var script = {
     }
   },
   watch: {
-    value: {
-      handler: undefined.handlerUpdate(val),
-      immediate: true
+    value: function value(val) {
+      try {
+        if (this.instance) {
+          this.update(val);
+        }
+      } catch (e) {}
     },
-    readOnlyMode: {
-      handler: undefined.handlerReadOnlyMode(val),
-      immediate: true
+    readOnlyMode: function readOnlyMode(val) {
+      this.instance.setReadOnly(val);
     }
   },
   mounted: function mounted() {
@@ -153,16 +155,6 @@ var script = {
           _this2.onChange();
         });
       }
-    },
-    handlerUpdate: function handlerUpdate(val) {
-      try {
-        if (this.instance) {
-          this.update(val);
-        }
-      } catch (e) {}
-    },
-    handlerReadOnlyMode: function handlerReadOnlyMode(val) {
-      this.instance.setReadOnly(val);
     }
   }
 };

diff --git a/dist/vue-ckeditor2.es.js b/dist/vue-ckeditor2.es.js
@@ -62,13 +62,15 @@ var script = {
     }
   },
   watch: {
-    value: {
-      handler: undefined.handlerUpdate(val),
-      immediate: true
+    value: function value(val) {
+      try {
+        if (this.instance) {
+          this.update(val);
+        }
+      } catch (e) {}
     },
-    readOnlyMode: {
-      handler: undefined.handlerReadOnlyMode(val),
-      immediate: true
+    readOnlyMode: function readOnlyMode(val) {
+      this.instance.setReadOnly(val);
     }
   },
   mounted: function mounted() {
@@ -149,16 +151,6 @@ var script = {
           _this2.onChange();
         });
       }
-    },
-    handlerUpdate: function handlerUpdate(val) {
-      try {
-        if (this.instance) {
-          this.update(val);
-        }
-      } catch (e) {}
-    },
-    handlerReadOnlyMode: function handlerReadOnlyMode(val) {
-      this.instance.setReadOnly(val);
     }
   }
 };

diff --git a/dist/vue-ckeditor2.js b/dist/vue-ckeditor2.js
@@ -71,13 +71,15 @@
       }
     },
     watch: {
-      value: {
-        handler: undefined.handlerUpdate(val),
-        immediate: true
+      value: function value(val) {
+        try {
+          if (this.instance) {
+            this.update(val);
+          }
+        } catch (e) {}
       },
-      readOnlyMode: {
-        handler: undefined.handlerReadOnlyMode(val),
-        immediate: true
+      readOnlyMode: function readOnlyMode(val) {
+        this.instance.setReadOnly(val);
       }
     },
     mounted: function mounted() {
@@ -158,16 +160,6 @@
             _this2.onChange();
           });
         }
-      },
-      handlerUpdate: function handlerUpdate(val) {
-        try {
-          if (this.instance) {
-            this.update(val);
-          }
-        } catch (e) {}
-      },
-      handlerReadOnlyMode: function handlerReadOnlyMode(val) {
-        this.instance.setReadOnly(val);
       }
     }
   };

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vue-ckeditor2",
-  "version": "2.0.8",
+  "version": "2.0.9",
   "description": "Ckeditor 4 using with Vue.js",
   "author": "Dang Van Thanh <[email protected]>",
   "main": "dist/vue-ckeditor2.cjs.js",

diff --git a/src/VueCkeditor.vue b/src/VueCkeditor.vue
@@ -56,13 +56,15 @@ export default {
     }
   },
   watch: {
-    value: {
-      handler: this.handlerUpdate(val),
-      immediate: true
+    value(val) {
+      try {
+        if (this.instance) {
+          this.update(val);
+        }
+      } catch (e) {}
     },
-    readOnlyMode: {
-      handler: this.handlerReadOnlyMode(val),
-      immediate: true
+    readOnlyMode(val) {
+      this.instance.setReadOnly(val);
     }
   },
   mounted() {
@@ -135,16 +137,6 @@ export default {
           this.onChange();
         });
       }
-    },
-    handlerUpdate(val) {
-      try {
-        if (this.instance) {
-          this.update(val);
-        }
-      } catch (e) {}
-    },
-    handlerReadOnlyMode(val) {
-      this.instance.setReadOnly(val);
     }
   }
 };