fix: Always collect Iterator[IntoExpr] in utils.flatten

Fixes narwhals-dev#1897
dangotbanned · Feb 4, 2025 · 50b56de · 50b56de
1 parent 4a2ca52
commit 50b56de
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/narwhals/utils.py b/narwhals/utils.py
@@ -387,11 +387,7 @@ def remove_suffix(text: str, suffix: str) -> str:  # pragma: no cover
 
 
 def flatten(args: Any) -> list[Any]:
-    if not args:
-        return []
-    if len(args) == 1 and _is_iterable(args[0]):
-        return args[0]  # type: ignore[no-any-return]
-    return args  # type: ignore[no-any-return]
+    return list(args[0] if (len(args) == 1 and _is_iterable(args[0])) else args)
 
 
 def tupleify(arg: Any) -> Any: