[GB] Removes unnecessary inline CSS and adds a CSS class.#7
Open
graemeblackwood wants to merge 1 commit intodanfinlay:masterfrom
Open
[GB] Removes unnecessary inline CSS and adds a CSS class.#7graemeblackwood wants to merge 1 commit intodanfinlay:masterfrom
graemeblackwood wants to merge 1 commit intodanfinlay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few suggested improvements.
Add a CSS class of identicon. Could also be "jazzicon" if preferred? This enables overriding of any of the inline CSS.
Border radius to 50%, so it auto matches the width and height. Right now, 50px would be too small if my width / height > 100.
Display: block, because inline-block adds space under the element, messing with positioning.
Remove padding and margin 0 as no browser applies these by default anyway.