Collapse Images

[ericholguin]

This PR allows users to collapse images, essentially just showing the url link instead of the image:

nostr:note1v82v8td4qmjxneg3xgkycas4mdkgakxzhtmmen8yfdzfs6he8gfqusu5jm

https://damus.io/note1v82v8td4qmjxneg3xgkycas4mdkgakxzhtmmen8yfdzfs6he8gfqusu5jm

[jb55]

On Sat, Oct 14, 2023 at 04:44:51PM -0600, ericholguin wrote: This PR allows users to collapse images, essentially just showing the url link instead of the image: nostr:note1v82v8td4qmjxneg3xgkycas4mdkgakxzhtmmen8yfdzfs6he8gfqusu5jm You can view, comment on, or merge this pull request online at:

we should wrap this into Low-data mode #919 so instead of having "collapse images" we would just have "low data mode" and include this PR. I will start a low-data-mode branch and include these changes.

[jb55]

+ Toggle(NSLocalizedString("Blur images", comment: "Setting to blur images"), isOn: $settings.blur_images) + .toggleStyle(.switch) + + Toggle(NSLocalizedString("Collapse images", comment: "Setting to only show image links"), isOn: $settings.collapse_images)

please only one change per patch. I do like that the "Always show images" was renamed, but I can't merge this patch because I'm not sure "Collapse images" is the right approach just yet (low-data-mode, etc)

[ericholguin]

Okay I think I fixed this

[ericholguin]

As for low data mode - I would like this option in general, specifically on iPads, images are hard to view so I'd rather just collapse them, even though I don't need Low Data in that case.

[jb55]

On Thu, Oct 26, 2023 at 06:47:40PM -0700, Eric Holguin wrote: Okay I think I fixed this

thanks, will take another look

[jb55]

On Sat, Oct 14, 2023 at 04:46:58PM -0600, ericholguin wrote: Okay I think I fixed this

looks like it's only 1 patch now which still mixes the two changes together. It also looks like the blur_images field was changed without the setting getting updated, they are the inverse of each other.

[ericholguin]

Closing as I messed up the commits and this needs better UX