Skip to content

Conversation

@dan-42
Copy link
Contributor

@dan-42 dan-42 commented Oct 14, 2016

Hey @daminetreg as we discussed, this will force the user to maintain include order.

I do the following,

  • if the base parser or generator include guard is already present ->error and stop compiling
  • if there not there, do your stuff, the explicit include karma or qi because if you include youre header, you want qi or karma
  • check if now the include guard is set, if not -> error because then the first check did not work either!

what do you say?

@dan-42
Copy link
Contributor Author

dan-42 commented Oct 14, 2016

works just found another issue in ninja wookie

Scanning dependencies of target wookie
[  1%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/service/service/detail/service_grammar.cpp.o
[  2%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/apdu/frame/grammar.cpp.o
[  3%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/npdu/detail/grammar.cpp.o
[  5%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/bvll/frames.cpp.o
[  6%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/npdu/frame.cpp.o
In file included from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/frames.hpp:29:0,
                 from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/grammar.hpp:26,
                 from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/grammar.cpp:24:
/home/frieddan/git/ninja-wookie/src/mapbox/boost_spirit_qi.hpp:9:4: error: #error "ERROR file must be included before boost spirit qi"
   #error "ERROR file must be included before boost spirit qi"
    ^
In file included from /home/frieddan/git/ninja-wookie/src/bacnet/npdu/frame.hpp:31:0,
                 from /home/frieddan/git/ninja-wookie/src/bacnet/npdu/detail/grammar.hpp:26,
                 from /home/frieddan/git/ninja-wookie/src/bacnet/npdu/detail/grammar.cpp:21:
/home/frieddan/git/ninja-wookie/src/mapbox/boost_spirit_qi.hpp:9:4: error: #error "ERROR file must be included before boost spirit qi"
   #error "ERROR file must be included before boost spirit qi"
    ^
In file included from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/detail/is_dereferenceable.hpp:12:0,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/detail/resolve.hpp:26,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/detail/push.hpp:24,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:31,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/stream_buffer.hpp:22,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/stream.hpp:21,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/home/qi/stream/detail/iterator_source.hpp:14,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/home/qi/stream/stream.hpp:16,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/home/qi/stream.hpp:15,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/home/qi.hpp:30,
                 from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/include/qi.hpp:16,
                 from /home/frieddan/git/ninja-wookie/src/bacnet/detail/common/types.hpp:15,
                 from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/grammar.hpp:25,
                 from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/grammar.cpp:24:
/home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/type_traits/detail/bool_trait_def.hpp:18:79: note: #pragma message: NOTE: Use of this header (bool_trait_def.hpp) is deprecated
 # pragma message("NOTE: Use of this header (bool_trait_def.hpp) is deprecated")
                                                                               ^

dan-42 pushed a commit to dan-42/lib-cpp-pre that referenced this pull request Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant