Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache not updating correctly #21

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: cache not updating correctly #21

merged 1 commit into from
Jan 25, 2024

Conversation

daithihearn
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c14da47) 85.96% compared to head (636fb43) 86.42%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/game/game-service.go 90.90% 1 Missing and 1 partial ⚠️
pkg/game/game-utils.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   85.96%   86.42%   +0.45%     
==========================================
  Files           5        5              
  Lines         962      965       +3     
==========================================
+ Hits          827      834       +7     
+ Misses         78       76       -2     
+ Partials       57       55       -2     
Flag Coverage Δ
unittests 86.42% <86.66%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daithihearn daithihearn merged commit f04397c into main Jan 25, 2024
4 checks passed
@daithihearn daithihearn deleted the cache-not-updating branch January 25, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant