Skip to content

add naive anova predictor#120

Merged
JudithBernett merged 7 commits intodevelopmentfrom
anova
Feb 7, 2025
Merged

add naive anova predictor#120
JudithBernett merged 7 commits intodevelopmentfrom
anova

Conversation

@PascalIversen
Copy link
Copy Markdown
Collaborator

@PascalIversen PascalIversen commented Feb 5, 2025

adds NaiveANOVAPredictor, a new baseline model based on a simple two-way ANOVA e.g. linear reg based on identities. No features used. Basically a mix between NaiveDrugMean and NaiveCellLineMean

for LPO GDSC2:

PearsonRResult(statistic=0.8972672876888541, pvalue=0.0)
vs NaiveDrugMeanPredictor (PearsonRResult(statistic=0.8277340222232414, pvalue=0.0))

image

For LCO the model is equivalent to the NaiveDrugMeanPredictor.

I think it makes sense to report any performance improvement relative to this baseline.

Copy link
Copy Markdown
Contributor

@JudithBernett JudithBernett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! But pls add documentation for the readthedocs

@PascalIversen
Copy link
Copy Markdown
Collaborator Author

done

@JudithBernett JudithBernett merged commit 0636bd3 into development Feb 7, 2025
25 checks passed
@JudithBernett JudithBernett deleted the anova branch February 7, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants