Merged
Conversation
JudithBernett
requested changes
Feb 6, 2025
Contributor
JudithBernett
left a comment
There was a problem hiding this comment.
Approved! But pls add documentation for the readthedocs
Collaborator
Author
|
done |
JudithBernett
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds NaiveANOVAPredictor, a new baseline model based on a simple two-way ANOVA e.g. linear reg based on identities. No features used. Basically a mix between NaiveDrugMean and NaiveCellLineMean
for LPO GDSC2:
PearsonRResult(statistic=0.8972672876888541, pvalue=0.0)
vs NaiveDrugMeanPredictor (PearsonRResult(statistic=0.8277340222232414, pvalue=0.0))
For LCO the model is equivalent to the NaiveDrugMeanPredictor.
I think it makes sense to report any performance improvement relative to this baseline.