Clear image list cache #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dersmon
reviewed
Dec 11, 2023
| @@ -4,6 +4,7 @@ defmodule FieldHub.FileStore do | |||
| @valid_file_variants Application.compile_env(:field_hub, :valid_file_variants) | |||
| @index_cache_name Application.compile_env(:field_hub, :file_index_cache_name) | |||
| @index_cache_expiration_ms 1000 * 60 * 60 * 24 | |||
| # @index_cache_expiration_ms 3000 | |||
There was a problem hiding this comment.
What did you try here? This line should probably be deleted at the end.
There was a problem hiding this comment.
Yes, I wanted to see what happened without wait one day.
Comment on lines
122
to
123
| new_cache = "Delete or update cache in this handle_event" | ||
| cache_index = FieldHub.FileStore.file_index(project) |
There was a problem hiding this comment.
For the ticket you do not need to create a new cache, that is already handled by the FileStore internally.
The only thing that has to be triggered from the interface is the FileStore's function to clear the existing cache. If you want to have a look how the file index looks like, you could for example use the Desktop client to push new images into the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.