feat: squad list view #4710
Merged
feat: squad list view #4710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
AmarTrebinjac
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rebelchris
requested changes
Jul 18, 2025
| @@ -49,7 +49,8 @@ function FeedItemContainer( | |||
| ? `${trending} devs read it last hour` | |||
| : undefined; | |||
| const isFeedPreview = useFeedPreviewMode(); | |||
| const showFlag = (!!pinnedAt || !!trending) && !isFeedPreview && description; | |||
| const showFlag = | |||
There was a problem hiding this comment.
Why was this change needed?
There was a problem hiding this comment.
@rebelchris Because without the pinned flag isn't visible. I looked at freeform grid version of it now which is the following: (!!pinnedAt || !!trending) && !isFeedPreview}. I'll change this one to be the same!
| @@ -214,29 +212,31 @@ const SquadPage = ({ handle, initialData }: SourcePageProps): ReactElement => { | |||
| <SquadPageHeader | |||
| squad={squad} | |||
| members={squadMembers} | |||
| shouldUseListMode={shouldUseListMode} | |||
| shouldUseListMode={false} | |||
There was a problem hiding this comment.
We should either remove this or keep dynamic no?
There was a problem hiding this comment.
@rebelchris I checked with Tsahi. Waiting for feedback :)
sshanzel
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enables list view on squad page. While this was primarily done to update the mobile feed to be in line with the rest of the feeds, we decided to also allow list view on larger devices.
This also naturally fixes this and this bug
Mobile before:
ScreenRecording_07-17-2025.23-23-26_1.MP4
Mobile after:
ScreenRecording_07-18-2025.01-48-36_1.MP4
Desktop:
Screen.Recording.2025-07-18.at.01.51.19.mov
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-945
Preview domain
https://mi-945.preview.app.daily.dev