Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ios native review followup #4112

Merged
merged 3 commits into from
Jan 28, 2025
Merged

feat: ios native review followup #4112

merged 3 commits into from
Jan 28, 2025

Conversation

idoshamun
Copy link
Member

@idoshamun idoshamun commented Jan 27, 2025 •
edited
Loading

Remove Plus and embed ios specific styles.

Preview domain

https://more-ios.preview.app.daily.dev

@idoshamun
feat: ios native review followup
94c55b8 
First commit to remove Plus and embed ios specific styles.

More to come...
@vercel Vercel
Copy link

vercel bot commented Jan 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 28, 2025 10:52am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 28, 2025 10:52am

@idoshamun idoshamun marked this pull request as ready for review January 27, 2025 19:00
@idoshamun idoshamun requested a review from a team as a code owner January 27, 2025 19:00
@idoshamun idoshamun enabled auto-merge (squash) January 28, 2025 10:50
@idoshamun idoshamun merged commit 1b272fb into main Jan 28, 2025
10 checks passed
@idoshamun idoshamun deleted the more-ios branch January 28, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@sshanzel sshanzel Awaiting requested review from sshanzel sshanzel is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

@AmarTrebinjac AmarTrebinjac Awaiting requested review from AmarTrebinjac AmarTrebinjac is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idoshamun @rebelchris