feat: Force user to go through onboarding steps for every registration #4014

AmarTrebinjac · 2024-12-22T17:30:32Z

Changes

This should prevent the user from refreshing to skip the necessary steps. Users created before the given date (currently 08-01-2 5) will not be required to complete the onboarding

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

MI-700 #done

Preview domain

https://mi-700.preview.app.daily.dev

vercel · 2024-12-22T17:30:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
daily-webapp	✅ Ready (Inspect)	Visit Preview	Jan 10, 2025 1:34pm

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
storybook	⬜️ Ignored (Inspect)		Jan 10, 2025 1:34pm

sshanzel · 2025-01-03T10:49:12Z

Either we retro-fix the missing action for existing users, or check the useMyFeed (can't remember the exact name), to check whether any changes were applied to their settings, if so, that would mean the user adjusted their feed already and must not redirect back to onboarding.

AmarTrebinjac · 2025-01-07T13:13:54Z

Either we retro-fix the missing action for existing users, or check the useMyFeed (can't remember the exact name), to check whether any changes were applied to their settings, if so, that would mean the user adjusted their feed already and must not redirect back to onboarding.

@sshanzelI tried creating an user where I skipped tags and settings, then I tried using "useFeedSettings" and both tags and advanced settings is filled with a lot of default stuff. So not sure we can check that way

sshanzel · 2025-01-07T14:44:13Z

Either we retro-fix the missing action for existing users, or check the useMyFeed (can't remember the exact name), to check whether any changes were applied to their settings, if so, that would mean the user adjusted their feed already and must not redirect back to onboarding.

@sshanzelI tried creating an user where I skipped tags and settings, then I tried using "useFeedSettings" and both tags and advanced settings is filled with a lot of default stuff. So not sure we can check that way

If you skip the tags part, the followTags will be empty, iirc.

AmarTrebinjac · 2025-01-07T16:06:39Z

Either we retro-fix the missing action for existing users, or check the useMyFeed (can't remember the exact name), to check whether any changes were applied to their settings, if so, that would mean the user adjusted their feed already and must not redirect back to onboarding.

@sshanzelI tried creating an user where I skipped tags and settings, then I tried using "useFeedSettings" and both tags and advanced settings is filled with a lot of default stuff. So not sure we can check that way

If you skip the tags part, the followTags will be empty, iirc.

For reference to anyone reading, responded to this here

rebelchris · 2025-01-08T12:53:20Z

packages/shared/src/hooks/auth/useOnboarding.tsx

+      Anyone who created an account before this date is exempt from the requirement.
+    */
+    const registeredBeforeRequired =
+      user?.createdAt && new Date(user.createdAt) < new Date('2025-01-08');


This will have to match exactly release right?

@rebelchris Not necessarily. If we want to give time for the extension to get published and stuff, we could just set the date a few days in the future. We don't necessarily have to start redirecting users exactly on merge date.

And new extension installs will have to install the newest version, right?

Yes, and do you redirect extension as well?
I'm not sure i'm seeing that part now

The changes in App.tsx are for the extension specifically, while the changes in _app.tsx are for the webapp.

Running pnpm --filter extension dev:chrome and then opening a new tab with a user registered after the given date redirects me to onboarding. Have I missed something? 🤔

Then it's fine, maybe we'll need to check with Ido what he thinks on extension vs non extension usage here?

Instead of redirecting immediately can we use the "hijacking" page (or whatever it's called) with slightly different copy and on click it redirects to onboarding? I already see the hate of us auto redirecting and users losing focus

@idoshamun Not entirely sure what you are referencing here. This is not supposed to affect existing users, and users trying to skip it should never have access to the rest of the page anyway, so they shouldn't really notice the redirecting.

chrome_MspWbpuF2k.mp4

Also, on the extension part, you can't access the extension without logging in, right? So users who installed and registered after the given date should not be able to bypass the onboarding in any way, webapp or extension.

i'm talking specifically on extension, automatically redirecting the extension to onboarding page will lead to complaints that i'd like to avoid. Try to use the extension without being logged in and you'll see the solution i'm referring to

i'm talking specifically on extension, automatically redirecting the extension to onboarding page will lead to complaints that i'd like to avoid. Try to use the extension without being logged in and you'll see the solution i'm referring to

Alright, I think I'm picking up what you're putting down. You basically want me to show this screen instead on the extension:

Should be able to make that happen

rebelchris

How about extension? 👀

AmarTrebinjac · 2025-01-10T13:35:08Z

@rebelchris Do you have a suggested cutoff date?

rebelchris

Overall looks good, but it's a super, super sensitive flow.
Can we maybe do a sync where you can show me flows from extension and webapp?

Rather double sanity check this then just rolling it out 🙏
(@sshanzel FYI, you might also want to look)

rebelchris · 2025-01-14T11:56:27Z

packages/extension/src/newtab/App.tsx

+  const isOnboardingComplete =
+    isOnboardingReady && hasCompletedEditTags && hasCompletedContentTypes;
+  const shouldRedirectOnboarding =
+    isPageReady && (!user || !isOnboardingComplete) && !isTesting;


Doesn't this affect current users now? (I didn't test it)

feat: Force user to go through onboarding steps for every registration

5985be6

Merge branch 'main' into MI-700

e3a1f82

vercel bot deployed to Preview – daily-webapp December 22, 2024 17:34 View deployment

AmarTrebinjac marked this pull request as ready for review December 22, 2024 17:36

AmarTrebinjac requested a review from a team as a code owner December 22, 2024 17:36

AmarTrebinjac requested review from rebelchris, omBratteng, ilasw, capJavert, sshanzel and nensidosari December 22, 2024 17:36

AmarTrebinjac added 2 commits January 1, 2025 13:22

extend check beyond onboarding

a412c78

Merge branch 'main' into MI-700

c9ed1b1

vercel bot deployed to Preview – daily-webapp January 1, 2025 12:26 View deployment

Merge branch 'main' into MI-700

0252913

vercel bot deployed to Preview – daily-webapp January 3, 2025 08:47 View deployment

Merge branch 'main' into MI-700

36eae31

vercel bot had a problem deploying to Preview – daily-webapp January 7, 2025 12:50 Failure

lint

0676072

vercel bot deployed to Preview – daily-webapp January 7, 2025 13:02 View deployment

update logic to use date and let old users skip

fb7c833

vercel bot deployed to Preview – daily-webapp January 7, 2025 20:10 View deployment

updated extension App.tsx

ddbe413

vercel bot deployed to Preview – daily-webapp January 8, 2025 09:32 View deployment

remove unused import

010f935

vercel bot deployed to Preview – daily-webapp January 8, 2025 10:12 View deployment

AmarTrebinjac added 2 commits January 8, 2025 11:13

remove unused function

44ac9bf

remove router as dependency

715a708

vercel bot deployed to Preview – daily-webapp January 8, 2025 10:17 View deployment

Merge branch 'main' into MI-700

a64ba27

vercel bot deployed to Preview – daily-webapp January 8, 2025 10:20 View deployment

rebelchris reviewed Jan 8, 2025

View reviewed changes

rebelchris requested changes Jan 8, 2025

View reviewed changes

undo automatic redirect for extension

90723e5

AmarTrebinjac requested review from idoshamun and rebelchris January 10, 2025 13:33

vercel bot deployed to Preview – daily-webapp January 10, 2025 13:34 View deployment

idoshamun approved these changes Jan 12, 2025

View reviewed changes

rebelchris approved these changes Jan 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Force user to go through onboarding steps for every registration #4014

feat: Force user to go through onboarding steps for every registration #4014

AmarTrebinjac commented Dec 22, 2024 •

edited

Loading

vercel bot commented Dec 22, 2024 •

edited

Loading

sshanzel commented Jan 3, 2025

AmarTrebinjac commented Jan 7, 2025

sshanzel commented Jan 7, 2025 •

edited

Loading

AmarTrebinjac commented Jan 7, 2025

rebelchris Jan 8, 2025

AmarTrebinjac Jan 8, 2025 •

edited

Loading

rebelchris Jan 8, 2025

AmarTrebinjac Jan 8, 2025

rebelchris Jan 8, 2025

idoshamun Jan 8, 2025

AmarTrebinjac Jan 9, 2025

idoshamun Jan 9, 2025

AmarTrebinjac Jan 9, 2025 •

edited

Loading

idoshamun Jan 9, 2025

rebelchris left a comment

AmarTrebinjac commented Jan 10, 2025

rebelchris left a comment

rebelchris Jan 14, 2025

feat: Force user to go through onboarding steps for every registration #4014

Are you sure you want to change the base?

feat: Force user to go through onboarding steps for every registration #4014

Conversation

AmarTrebinjac commented Dec 22, 2024 • edited Loading

Changes

Events

Experiment

Manual Testing

Preview domain

vercel bot commented Dec 22, 2024 • edited Loading

sshanzel commented Jan 3, 2025

AmarTrebinjac commented Jan 7, 2025

sshanzel commented Jan 7, 2025 • edited Loading

AmarTrebinjac commented Jan 7, 2025

Choose a reason for hiding this comment

AmarTrebinjac Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AmarTrebinjac Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rebelchris left a comment

Choose a reason for hiding this comment

AmarTrebinjac commented Jan 10, 2025

rebelchris left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AmarTrebinjac commented Dec 22, 2024 •

edited

Loading

vercel bot commented Dec 22, 2024 •

edited

Loading

sshanzel commented Jan 7, 2025 •

edited

Loading

AmarTrebinjac Jan 8, 2025 •

edited

Loading

AmarTrebinjac Jan 9, 2025 •

edited

Loading