feat(create-waku): install dependencies automatically when creating a…

… new waku project (#808)

follow up #728

- [x] implement a new feature

---------

Co-authored-by: Joel Mathew Koshy <[email protected]>
Co-authored-by: Daishi Kato <[email protected]>

e2e/create-waku.spec.ts

@@ -1,8 +1,8 @@
-import { spawn } from 'node:child_process';
+import { exec, spawn } from 'node:child_process';
 import { fileURLToPath } from 'node:url';
 import crypto from 'node:crypto';
 import { mkdir, readdir, cp, readFile, writeFile } from 'node:fs/promises';
-import { test, debugChildProcess, terminate } from './utils.js';
+import { test, debugChildProcess } from './utils.js';
 import { expect } from '@playwright/test';
 
 test('should create waku with default setup work', async () => {
@@ -43,7 +43,7 @@ test('should create waku with default setup work', async () => {
   expect(files).toContain('package.json');
   expect(files).toContain('src');
   expect(files).toContain('tsconfig.json');
-  await terminate(childProcess.pid!);
+  exec(`rm -rf ${cwd}`);
 });
 
 test('should create waku with update notify work', async () => {
@@ -87,5 +87,6 @@ test('should create waku with update notify work', async () => {
       break;
     }
   }
+  exec(`rm -rf ${cwd}`);
   // no need to kill the process, it will exit by itself
 });

packages/create-waku/src/index.ts

@@ -16,6 +16,7 @@ import {
   parseExampleOption,
   downloadAndExtract,
 } from './helpers/example-option.js';
+import { spawn } from 'node:child_process';
 
 const userAgent = process.env.npm_config_user_agent || '';
 const packageManager = /pnpm/.test(userAgent)
@@ -202,15 +203,32 @@ async function init() {
     await installTemplate(root, packageName, templateRoot, templateName);
   }
 
-  // TODO automatically installing dependencies
   // 1. check packageManager
   // 2. and then install dependencies
-
-  console.log(`\nDone. Now run:\n`);
-  console.log(`${bold(green(`cd ${targetDir}`))}`);
-  console.log(`${bold(green(commands.install))}`);
-  console.log(`${bold(green(commands.dev))}`);
   console.log();
+  console.log(`Installing dependencies by running ${commands.install}...`);
+
+  const installProcess = spawn(packageManager, ['install'], {
+    stdio: 'inherit',
+    shell: process.platform === 'win32',
+    cwd: targetDir,
+  });
+
+  installProcess.on('close', (code) => {
+    // process exit code
+    if (code !== 0) {
+      console.error(`Could not execute ${commands.install}. Please run`);
+      console.log(`${bold(green(`cd ${targetDir}`))}`);
+      console.log(`${bold(green(commands.install))}`);
+      console.log(`${bold(green(commands.dev))}`);
+      console.log();
+    } else {
+      console.log(`\nDone. Now run:\n`);
+      console.log(`${bold(green(`cd ${targetDir}`))}`);
+      console.log(`${bold(green(commands.dev))}`);
+      console.log();
+    }
+  });
 }
 
 init()