Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#755] dag: Support params as a list of key-value pairs #756

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Dec 30, 2024

Resolves #755

Example:

params:
  - FOO: foo
  - BAR: bar
  - BAZ: "`echo baz`"
steps:
  - name: step_1
    command: |
      echo ${FOO} ${BAR} ${BAZ}

@yohamta yohamta changed the title [#755] dag: Support params as map [#755] dag: Support params as a list of key-value pairs Dec 30, 2024
@yohamta yohamta merged commit fc360a6 into main Dec 30, 2024
4 checks passed
@yohamta yohamta deleted the param-as-map branch December 30, 2024 11:54
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 75.38462% with 32 lines in your changes missing coverage. Please review.

Project coverage is 58.29%. Comparing base (b151210) to head (b9e3d08).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/digraph/params.go 75.38% 25 Missing and 7 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   58.11%   58.29%   +0.18%     
==========================================
  Files          68       68              
  Lines        6640     6729      +89     
==========================================
+ Hits         3859     3923      +64     
- Misses       2474     2495      +21     
- Partials      307      311       +4     
Files with missing lines Coverage Δ
internal/digraph/params.go 80.45% <75.38%> (-8.96%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b151210...b9e3d08. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dag: Support Defining params as a list of key-value pairs in YAML Configuration
1 participant