Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: Enable Command Substitution for RetryPolicy configuration #747

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Dec 25, 2024

  • Enabled command substitution and environment variables for retry policy configuration

@yohamta yohamta merged commit 6ca7f2a into main Dec 25, 2024
5 checks passed
@yohamta yohamta deleted the fix-retrypolicy branch December 25, 2024 08:52
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 33.92857% with 37 lines in your changes missing coverage. Please review.

Project coverage is 58.57%. Comparing base (3093ae2) to head (d622e4f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/digraph/scheduler/node.go 42.30% 12 Missing and 3 partials ⚠️
internal/cmdutil/cmdutil.go 0.00% 14 Missing ⚠️
internal/digraph/builder.go 42.85% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   58.87%   58.57%   -0.31%     
==========================================
  Files          68       68              
  Lines        6560     6609      +49     
==========================================
+ Hits         3862     3871       +9     
- Misses       2394     2430      +36     
- Partials      304      308       +4     
Files with missing lines Coverage Δ
internal/digraph/scheduler/scheduler.go 83.28% <100.00%> (ø)
internal/digraph/step.go 100.00% <ø> (ø)
internal/digraph/builder.go 72.95% <42.85%> (-1.46%) ⬇️
internal/cmdutil/cmdutil.go 67.72% <0.00%> (-5.42%) ⬇️
internal/digraph/scheduler/node.go 76.33% <42.30%> (-2.69%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3093ae2...d622e4f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant