Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#736] add TLS skip verification option for remote node #739

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Dec 10, 2024

Related: #736

Add skipTLSVerify configuration option for remote nodes that allows users to control TLS certificate verification on a per-node basis.

Example configuration:

remoteNodes:
  - name: "DEV"
    apiBaseUrl: "https://dev-server:8443/api/v1"
    isAuthToken: true
    authToken: "..."
    skipTLSVerify: true  # Skip TLS verification for this node

@yohamta yohamta merged commit 5af66f1 into main Dec 10, 2024
5 checks passed
@yohamta yohamta deleted the 736-hotfix branch December 10, 2024 13:45
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.64%. Comparing base (3bcdca9) to head (bfe01b8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   61.64%   61.64%           
=======================================
  Files          53       53           
  Lines        5262     5262           
=======================================
  Hits         3244     3244           
  Misses       1764     1764           
  Partials      254      254           
Files with missing lines Coverage Δ
internal/config/config.go 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bcdca9...bfe01b8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant