Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#709] feat: Add skipIfSuccessful #712

Merged
merged 5 commits into from
Nov 15, 2024
Merged

[#709] feat: Add skipIfSuccessful #712

merged 5 commits into from
Nov 15, 2024

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Nov 15, 2024

Closes #709

@yohamta yohamta merged commit 2e627d8 into main Nov 15, 2024
5 checks passed
@yohamta yohamta deleted the 709-skip-if-successful branch November 15, 2024 09:42
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 61.80%. Comparing base (855e75d) to head (7dc145b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/scheduler/job.go 0.00% 16 Missing ⚠️
internal/scheduler/scheduler.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   61.97%   61.80%   -0.18%     
==========================================
  Files          53       53              
  Lines        5228     5249      +21     
==========================================
+ Hits         3240     3244       +4     
- Misses       1734     1751      +17     
  Partials      254      254              
Files with missing lines Coverage Δ
internal/dag/builder.go 77.50% <100.00%> (+0.20%) ⬆️
internal/dag/dag.go 76.56% <ø> (ø)
internal/scheduler/entryreader.go 67.82% <100.00%> (ø)
internal/scheduler/scheduler.go 63.57% <0.00%> (-0.93%) ⬇️
internal/scheduler/job.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855e75d...7dc145b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skipIfSuccessful option to prevent unnecessary DAG reruns
1 participant