Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff ify #139

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Ruff ify #139

merged 6 commits into from
Jan 3, 2025
+489 −393

Conversation

cnolanminich
Copy link
Contributor

@cnolanminich cnolanminich commented Jan 2, 2025 •
edited
Loading

ruff is a standard python linter and code formatter at this point. This PR adds ruff to our CI, a makefile command that mimics the command in the dagster-io/dagster repo, and I also ran make ruff and committed the changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

Your pull request at commit c68f96a803524c50922977ca8344c85cd9a70139 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
data-eng-pipeline View in Cloud Jan 03, 2025 at 07:17 PM (UTC)
basics View in Cloud Jan 03, 2025 at 07:17 PM (UTC)
hooli_bi View in Cloud Jan 03, 2025 at 07:17 PM (UTC)
batch_enrichment View in Cloud Jan 03, 2025 at 07:17 PM (UTC)
hooli_data_ingest View in Cloud Jan 03, 2025 at 07:17 PM (UTC)
snowflake_insights View in Cloud Jan 03, 2025 at 07:17 PM (UTC)

@cnolanminich cnolanminich marked this pull request as ready for review January 3, 2025 19:17
slopp
slopp approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@slopp slopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too scary to actually review lol but I trust it runs

thanks!

@cnolanminich cnolanminich merged commit bc1dc3e into master Jan 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopp slopp slopp approved these changes

@izzye84 izzye84 Awaiting requested review from izzye84

@thomasganka thomasganka Awaiting requested review from thomasganka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnolanminich @slopp