[ui] Add tabs to evaluation dialog #26960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 2efd92d. |
hellendag
force-pushed
the
dish/tabbed-evaluation-dialog
branch
2 times, most recently
from
9e22794 to
e1a95d6
Compare
OwenKephart
approved these changes
Jan 14, 2025
hellendag
force-pushed
the
dish/tabbed-evaluation-dialog
branch
from
e1a95d6 to
2efd92d
Compare
hellendag
force-pushed
the
dish/tabbed-evaluation-dialog
branch
from
2efd92d to
fead83e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Update
EvaluationDetailDialogto have two tabs: Evaluation and Runs. The first shows what the dialog currently shows, which is the details of the evaluation itself. The second is a filtered Runs table with the runs associated with the evaluation.How I Tested These Changes
View dialog from automation sensor and asset automations list. Verify that the tabs behave and render correctly.
Changelog
[ui] When viewing details of an automation evaluation, show the relevant runs in a tab within the same dialog.