thread pool information to graphql layer #26802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 529046e. |
prha
force-pushed
the
prha/external_concurrency
branch
from
ec8a4d6 to
d90c32d
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
2e29f0c to
081f3f6
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
d90c32d to
a1526d1
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
081f3f6 to
1b0c5a6
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
a1526d1 to
5ff2171
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
1b0c5a6 to
2050fcc
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
5ff2171 to
9b6bafd
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
2 times, most recently
from
9279774 to
06fa0b8
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
9b6bafd to
ce0a6fa
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
06fa0b8 to
f66d281
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
ce0a6fa to
51ab2b3
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
f66d281 to
4ce4b5d
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
51ab2b3 to
3c45061
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
4ce4b5d to
f0cec36
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
3c45061 to
5905530
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
2 times, most recently
from
adaea1b to
b4b7660
Compare
This was referenced Jan 9, 2025
prha
force-pushed
the
prha/external_concurrency
branch
from
f73ce28 to
37a3fc1
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
ae440df to
6345733
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
37a3fc1 to
b08e8a2
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
6345733 to
418533a
Compare
OwenKephart
approved these changes
Jan 14, 2025
| @@ -241,6 +241,7 @@ class GrapheneAssetNode(graphene.ObjectType): | |||
| backfillPolicy = graphene.Field(GrapheneBackfillPolicy) | |||
| changedReasons = graphene.Field(non_null_list(GrapheneAssetChangedReason)) | |||
| computeKind = graphene.String() | |||
| pools = non_null_list(graphene.String) | |||
There was a problem hiding this comment.
nit: I think these fields are supposed to be in alphabetical order (not that we've been doing a great job of that) -- seems like there's no particular reason for it to be in this spot over it's alphabetical place so probably better to put it down near the partition stuff
prha
force-pushed
the
prha/external_concurrency
branch
from
b08e8a2 to
c406982
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
418533a to
2aa1b31
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
c406982 to
7e2a6f3
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
2aa1b31 to
4ee7bb2
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
7e2a6f3 to
4fdcb49
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
4ee7bb2 to
a5c1061
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
4fdcb49 to
27f08bd
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
a5c1061 to
a122751
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
27f08bd to
b640e9c
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
a122751 to
edad1ab
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
b640e9c to
3e695a9
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
edad1ab to
e41ec46
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
3e695a9 to
d72bd90
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
e41ec46 to
5ea38ab
Compare
prha
force-pushed
the
prha/graphql_concurrency_group
branch
from
5ea38ab to
529046e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds a pools graphql field for ops and assets
How I Tested These Changes
BK